Fix undefined array key warnings in openswoole/swoole card templates#39
Merged
Conversation
…oole.phtml Use null coalescing operator (??) with 'disabled' fallback on all preg_match result accesses to prevent "Undefined array key 1" warnings when a regex pattern doesn't match the php --ri output. Co-authored-by: tillkruss <665029+tillkruss@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix undefined array key warnings in card-openswoole
Fix undefined array key warnings in openswoole/swoole card templates
Mar 5, 2026
Member
|
@dhobi do you happen to know if they renamed these or why it's suddenly not mentioned anymore? |
Member
|
tillkruss
added a commit
that referenced
this pull request
Mar 5, 2026
…39) Co-authored-by: tillkruss <665029+tillkruss@users.noreply.github.com>
tillkruss
added a commit
that referenced
this pull request
Mar 5, 2026
* heroku-22, heroku-24, php 8.1 - 8.5 with latest (#32) - Drops (unsupported) heroku-20 stack - Adds heroku-24 stack - Adds php 8.4 (20240924) - Adds php 8.5 (20250925) - Refactor build process - Fixed undefined array key warnings in openswoole/swoole card templates (#39) Co-authored-by: tillkruss <665029+tillkruss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preg_matchresult arrays are accessed at index[1]without checking for a match, causing PHP warnings when a feature key (e.g.json,curl-native,postgres) is absent fromphp --rioutput.?? 'disabled') to all 13preg_matchresult accesses acrosscard-openswoole.phtml(7) andcard-swoole.phtml(6)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.